[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] org-attach.el: Get attachments from git annex
|
From: |
Erik Hetzner |
|
Subject: |
Re: [O] [PATCH] org-attach.el: Get attachments from git annex |
|
Date: |
Mon, 08 Feb 2016 21:25:25 -0800 |
|
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (Gojō) APEL/10.8 EasyPG/1.0.0 Emacs/25.1.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
On Sun, 07 Feb 2016 12:48:20 -0800,
Achim Gratz <address@hidden> wrote:
>
> Erik Hetzner writes:
> > Thank you for all your feedback on this code! I’m really happy with how it
> > turned out, and glad it is in master now.
>
> Please fix the tests to not fail (preferrably not run) if git-annex is
> not installed.
>
> Also, revert the patch to mk/targets.mk; $(RMR) already includes the
> '--force' flag, so it can remove write protected files just fine. If
> it's write protecting directories then that would be stupid, but still
> no reason to chmod all files.
Hi Achim,
Sorry - I misunderstood how `org-test-for-executable' works. I’ll fix the issue.
As for the rm -rf, it does not work in the way you suggest, at least on ubuntu
GNU/Linux. Here is the result I get locally without the chmod:
make cleantest
make[1]: Entering directory '/home/egh/c/org-mode'
rm -fr /tmp/tmp-orgtest
rm: cannot remove
‘/tmp/tmp-orgtest/org-annex-test18033fml/.git/annex/objects/jm/P2/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447’:
Permission denied
rm: cannot remove
‘/tmp/tmp-orgtest/org-annex-test18033Scf/.git/annex/objects/jm/P2/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447’:
Permission denied
rm: cannot remove
‘/tmp/tmp-orgtest/org-annex-test172167kl/.git/annex/objects/jm/P2/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447’:
Permission denied
rm: cannot remove
‘/tmp/tmp-orgtest/org-annex-test17216uaf/.git/annex/objects/jm/P2/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447/SHA256E-s12--a948904f2f0f479b8f8197694b30184b0d2ed1c1cd2a1ec0fb85d299a192a447’:
Permission denied
mk/targets.mk:163: recipe for target 'cleantest' failed
make[1]: *** [cleantest] Error 1
make[1]: Leaving directory '/home/egh/c/org-mode'
mk/targets.mk:103: recipe for target 'test' failed
make: *** [test] Error 2
If you have a better suggestion to this issue I’d love to know! I’m not sure
what the best fix is here.
best, Erik
- [O] [PATCH] org-attach.el: Get attachments from git annex, Erik Hetzner, 2016/02/03
- Re: [O] [PATCH] org-attach.el: Get attachments from git annex, Kyle Meyer, 2016/02/04
- Re: [O] [PATCH] org-attach.el: Get attachments from git annex, Rasmus, 2016/02/06
- Re: [O] [PATCH] org-attach.el: Get attachments from git annex, Erik Hetzner, 2016/02/07
- Re: [O] [PATCH] org-attach.el: Get attachments from git annex, Achim Gratz, 2016/02/07
- Re: [O] [PATCH] org-attach.el: Get attachments from git annex,
Erik Hetzner <=
- Re: [O] [PATCH] org-attach.el: Get attachments from git annex, Achim Gratz, 2016/02/09
- Re: [O] [PATCH] org-attach.el: Get attachments from git annex, Erik Hetzner, 2016/02/09
- Re: [O] [PATCH] org-attach.el: Get attachments from git annex, Achim Gratz, 2016/02/09
- Re: [O] [PATCH] org-attach.el: Get attachments from git annex, Erik Hetzner, 2016/02/10
- Re: [O] [PATCH] org-attach.el: Get attachments from git annex, Achim Gratz, 2016/02/11
- [O] [PATCH] testing/lisp/test-org-attach-annex.el: New file, Erik Hetzner, 2016/02/09
- Re: [O] [PATCH] testing/lisp/test-org-attach-annex.el: New file, Achim Gratz, 2016/02/14