[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH]: Fix ob-haskell.el to work with custom ghci prompts
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH]: Fix ob-haskell.el to work with custom ghci prompts |
Date: |
Wed, 29 Nov 2017 21:21:34 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello,
Doro Rose <address@hidden> writes:
> Nicolas Goaziou <address@hidden> writes:
>
>> Hello,
>>
>> Doro Rose <address@hidden> writes:
>>
>>> In summary, yes I'm accessing user settings but in a rather
>>> noninvasive way. Unfortunately I can't think of a more elegant way to
>>> do this.
>>
>> Let's put it differently then. Isn't it the job of the user, who changed
>> their prompt, to configure properly "inf-haskell" library? I don't get
>> why it should be a task for "ob-haskell".
>>
>> This is a genuine question: I don't use Haskell at all.
>>
>> Regards,
>
> Well the "inf-haskell" library is fine as it is, i.e. the code sent to its
> buffer
> is evaluated correctly in the corresponding buffer.
> The problem occurs when sending code to that buffer via org-babel, since
> the interpreter output isn't parsed correctly in
> `org-babel-comint-with-output`.
>
> As an org-babel user my expectation would be for that to just work out of the
> box. -> Without having to figure out that I need to set internal variables
> defined in
> "inf-haskell" or that I need to add `ansi-color-filter-apply` to
> `comint-preoutput-filter-functions`.
Fair enough. Could you provide a proper commit message and send the
patch again?
Thank you.
Regards,
--
Nicolas Goaziou