[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] org-agenda: make log and clockreport modes local
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH] org-agenda: make log and clockreport modes local |
Date: |
Thu, 22 Feb 2018 14:39:36 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello,
Nicolas Dudebout <address@hidden> writes:
> `org-agenda-show-log' indicates if the the current agenda buffer has
> log-mode enabled. When building a new agenda buffer, it gets its
> value from `org-agenda-start-with-log-mode'. It is is semantically a
> buffer local variable: when creating a new agenda buffer you expect it
> to be set to the value in `org-agenda-start-with-log-mode'. However,
> 2e9c2d71 while fixing an issue with sticky agendas rendered the
> variable `org-agenda-log-mode' effectively global: toggling log mode
> in a given agenda buffer modifies the global default for all agenda
> buffers. The same reasoning holds for clockreport mode.
>
> This change ensures that a log or clockreport mode change made in one
> agenda buffer does not propagate to other agenda buffers, existing or
> new. The change is however preserved on org-agenda-redo in the
> initial agenda buffer, whether using sticky agendas or not.
Applied. Thank you.
I don't know if you signed FSF papers already. Therefore, I added
TINYCHANGE at the end of the commit message.
Regards,
--
Nicolas Goaziou