emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] migrate ob-clojure initiate session code from ob-clojure


From: stardiviner
Subject: Re: [O] [PATCH] migrate ob-clojure initiate session code from ob-clojure-literate.el into ob-clojure.el
Date: Tue, 23 Oct 2018 20:02:58 +0800
User-agent: mu4e 1.1.0; emacs 26.1

Nicolas Goaziou <address@hidden> writes:

Hi, sorry for late response, because I'm a little lazy on give effort on
review my patch and improve it again. But now I finished it. Actually I
corrected my patch as soon as you replied email with mentioned. Today I
pick up this task again, and add a new improve which support CIDER new
API which using sesman to manage REPL sessions.

>
> Would it make sense to add a few tests for this?
>
> Regards,

It is hard for me to write tests for CIDER session. It has some kind of 
interactive and don't know how to verify it.

Attachment: 0001-ob-clojure.el-Support-org-babel-initiate-session-to-.patch
Description: support initialize clojure session

Attachment: 0002-ob-clojure.el-Support-new-CIDER-using-sesman-to-mana.patch
Description: support new CIDER API with sesman to manage REPL sessions

As always, thank you for maintaining Org Mode and reviewing my patches and 
patient of my stupidity. Point out any issue if you found. Thanks again.

--
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.
       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

reply via email to

[Prev in Thread] Current Thread [Next in Thread]