emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] Fix C-u C-c C-q (align all tags in visible buffer)


From: Nicolas Goaziou
Subject: Re: [O] Fix C-u C-c C-q (align all tags in visible buffer)
Date: Fri, 04 Jan 2019 14:17:53 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hello,

Kaushal Modi <address@hidden> writes:

> This minor bug had been bothering me for a while and I eventually got to
> looking into the source code for it.
>
> As of current master, C-u C-c C-q doesn't work as in the doc-string i.e.
> "When optional argument ALL is non-nil, align all tags in the visible part
> of the buffer.".
>
> Here's an example Org buffer:
>
> =====
> * Foo :abc:
> ** Bar :def:
> =====
>
> - With point on Foo heading, C-u C-c C-q aligns only :def: tag (tags from
> *next* heading onwards).
> - So when point is on Bar, no tags get aligned.
>
> Though I remember that C-u C-c C-q worked quite some time back.
>
> A commit in Apr 28, 2018 broke that behavior in
> https://code.orgmode.org/bzg/org-mode/commit/1615261cdc5da6dbe50176d7958c775d6d54411e#diff-f9a90d66b3053f60bd4e8d63f214273067d0d28L14288
> .
>
> While I don't understand that entire commit, this simple fix brings back
> the true C-u C-c C-q behavior:
>
> diff --git a/lisp/org.el b/lisp/org.el
> index db3c11b5f..b8daa3bfc 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -14203,8 +14203,10 @@ visible part of the buffer."
>      (org--align-tags-here (funcall get-indent-column))
>        (save-excursion
>      (if all
> +            (progn
> +              (goto-char (point-min))
>            (while (re-search-forward org-tag-line-re nil t)
> -          (org--align-tags-here (funcall get-indent-column)))
> +            (org--align-tags-here (funcall get-indent-column))))
>        (org-back-to-heading t)
>        (org--align-tags-here (funcall get-indent-column)))))))
>
>
> If this looks good, I can commit this to maint and master.

Sure. Please also provide a regression test for it.

Thank you.

Regards,

-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]