[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Luc Teirlinck
Subject: Re:
Date: Tue, 27 May 2003 20:03:09 -0500 (CDT)

The following patch, in response to a bug report by Lennart Staflin,
of a week ago, has apparently not yet been committed.  Was there
something wrong with it or is this just due to the fact that one
thought I had write access and would commit it myself?  I did not have
write access then but do now and hence could commit it.  (Would give
me some "exercise".)  First I want to make sure that there are no
objections.  It seems like such an obvious typo: a character
alternative with the surrounding brackets missing.  (Or not?.)

Copy of my old posting:

Lennart Staflin wrote:

   If I evaluate:

       (setenv "T5" "Y")
       (substitute-env-vars "X$T5")

   I get:


   this should be "XY".

I believe that this is due to a typo in `substitute-env-vars'.
I believe that the following patch fixes it:

Change log:

2003-05-20  Luc Teirlinck  <address@hidden>

        * env.el (substitute-env-vars): Fix typo.


===File ~/envdiff===========================================
cd /usr/local/share/emacs/21.3.50/lisp/
diff -c /usr/local/share/emacs/21.3.50/lisp/env.old.el 
*** /usr/local/share/emacs/21.3.50/lisp/env.old.el      Wed May  7 15:00:42 
--- /usr/local/share/emacs/21.3.50/lisp/env.el  Tue May 20 11:54:10 2003
*** 68,74 ****
    (let ((start 0))
      (while (string-match
!             (rx (or (and "$" (submatch (1+ (regexp "[:alnum:]_"))))
                      (and "${" (submatch (minimal-match (0+ anything))) "}")
            string start)
--- 68,74 ----
    (let ((start 0))
      (while (string-match
!             (rx (or (and "$" (submatch (1+ (regexp "[[:alnum:]_]"))))
                      (and "${" (submatch (minimal-match (0+ anything))) "}")
            string start)

Diff finished at Tue May 20 11:59:06

reply via email to

[Prev in Thread] Current Thread [Next in Thread]