emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

optimization turned off


From: Dave Love
Subject: optimization turned off
Date: Tue, 29 Jul 2003 00:12:03 +0100
User-agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.2 (gnu/linux)

This change effectively turns off optimization unconditionally as far
as I can tell, since I don't see how OPTIMIZE can be defined.  I
assume that wasn't intentional, especially as there are now two
separate definitions of CFLAGS in src/Makefile.in, which is how I
noticed.  I don't know why you'd want to do that in configure anyway,
and I think the change should be taken out.  If I really need an
unoptimized build, I just do `make CFLAGS=-g'.

The changes to config.in shouldn't have been made there since it's a
generated file.  Anyhow, I don't see the point of the now-lost
OPTIMIZE change since inlining is only done with -O.

2003-07-12  Richard M. Stallman  <address@hidden>

        * Makefile.in (CFLAGS) [!OPTIMIZE]: Set CFLAGS to -g.

        * config.in (HAVE_CRTIN): Add #undef.
        (INLINE): Really inline only if OPTIMIZE is defined.

[The configure test for inlining being available should actually be
extended to consider other compilers, but it isn't worth trying to
special-case anything to turn it off with them.  I guess I never got
round to writing the test for `extern inline'.  However, it's not
clear to me that the few uses of `extern INLINE' are right anyhow,
since the function definition should be in the header.]




reply via email to

[Prev in Thread] Current Thread [Next in Thread]