emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [smtpmail.el] Recent change breaks queueing


From: Glenn Morris
Subject: Re: [smtpmail.el] Recent change breaks queueing
Date: Tue, 26 Aug 2003 17:43:33 +0100
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Jesper Harder wrote:

> This change breaks mail sending when `smtpmail-queue-mail' is t:
>
> 2003-08-24  Glenn Morris  <address@hidden>
>
>       * mail/sendmail.el (mail-specify-envelope-from): Doc change.    
>       * mail/smtpmail.el (smtpmail-mail-address): Doc change.
>       (smtpmail-send-it): Make treatment of envelope-from consistent with
>       sendmail.el.
>
> `smtpmail-mail-address' is not set to the correct value when sending
> queued mail -- which causes my mail server to refuse to send the mail.

Sorry about that. Does this help?

--- smtpmail.el 24 Aug 2003 15:23:12 -0000      1.58
+++ smtpmail.el 26 Aug 2003 16:39:52 -0000
@@ -401,11 +401,14 @@
        (with-temp-buffer
          (let ((coding-system-for-read 'no-conversion))
            (insert-file-contents file-msg))
+          (let ((smtpmail-mail-address
+                 (or (and mail-specify-envelope-from (mail-envelope-from))
+                     user-mail-address)))
          (if (not (null smtpmail-recipient-address-list))
              (if (not (smtpmail-via-smtp smtpmail-recipient-address-list
                                          (current-buffer)))
                  (error "Sending failed; SMTP protocol error"))
-           (error "Sending failed; no recipients")))
+              (error "Sending failed; no recipients"))))
        (delete-file file-msg)
        (delete-file (concat file-msg ".el"))
        (delete-region (point-at-bol) (point-at-bol 2)))





reply via email to

[Prev in Thread] Current Thread [Next in Thread]