emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Emacs 21.3.50 grep.el/executable.el problems


From: Markus Rost
Subject: Re: Emacs 21.3.50 grep.el/executable.el problems
Date: Wed, 18 Feb 2004 21:55:59 +0100

       another use of executable-command-find-posix-p, namely in
       filecache.el.  Maybe one should change that as well and then remove
       executable-command-find-posix-p.

   Someone said that filecache.el previously failed entirely to cope with
   a nonstandard find, so perhaps we lose nothing by leaving it in
   and we may as well fix it instead.

I just applied the following patch which ought to fix the mentioned
problems.  It uses `file-truename' to avoid possible symlink problems.

===Buffer *vc-diff*=========================================
Index: executable.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/progmodes/executable.el,v
retrieving revision 1.30
retrieving revision 1.31
diff -c -r1.30 -r1.31
*** executable.el       1 Feb 2004 16:27:00 -0000       1.30
--- executable.el       18 Feb 2004 20:47:46 -0000      1.31
***************
*** 145,156 ****
    "Check if PROGRAM handles arguments Posix-style.
  If PROGRAM is non-nil, use that instead of \"find\"."
    ;;  Pick file to search from location we know
!   (let* ((dir   (car load-path))
!          (file  (find-if
!                  (lambda (x)
!                    ;; Filter directories . and ..
!                    (not (string-match "^\\.\\.?$" x)))
!                  (directory-files dir))))
      (with-temp-buffer
        (call-process (or program "find")
                      nil
--- 145,152 ----
    "Check if PROGRAM handles arguments Posix-style.
  If PROGRAM is non-nil, use that instead of \"find\"."
    ;;  Pick file to search from location we know
!   (let* ((dir (file-truename data-directory))
!          (file (car (directory-files dir nil "^[^.]"))))
      (with-temp-buffer
        (call-process (or program "find")
                      nil
============================================================




reply via email to

[Prev in Thread] Current Thread [Next in Thread]