emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: View-quit sometimes refuses to quit


From: Richard Stallman
Subject: Re: View-quit sometimes refuses to quit
Date: Sat, 13 Mar 2004 21:54:57 -0500

    1. start CVS emacs with -q --no-site-file
    2. M-x list-faces-display
    3. Create a 2nd frame (C-x 5 2)
    4. In 2nd frame: M-x list-faces-display
    5. Entering "q" (for View-quit) in *Faces* buffer should quit this buffer.
       This works in 2nd frame, but not in 1st frame

Do these patches fix it?

*** view.el.~1.74.~     Sat Feb 14 11:11:44 2004
--- view.el     Sat Mar 13 18:57:29 2004
***************
*** 137,142 ****
--- 137,143 ----
  See RETURN-TO-ALIST argument of function `view-mode-exit' for the format of
  `view-return-to-alist'.")
  (make-variable-buffer-local 'view-return-to-alist)
+ (put 'view-return-to-alist 'permanent-local t)
  
  (defvar view-exit-action nil
    "nil or a function with one argument (a buffer) called when finished 
viewing.
*** help-mode.el.~1.22.~        Thu Jan  1 15:12:40 2004
--- help-mode.el        Sat Mar 13 18:44:40 2004
***************
*** 189,202 ****
  
  ;;;###autoload
  (defun help-mode-finish ()
    (when (eq major-mode 'help-mode)
      ;; View mode's read-only status of existing *Help* buffer is lost
      ;; by with-output-to-temp-buffer.
      (toggle-read-only 1)
!     (help-make-xrefs (current-buffer)))
!   (setq view-return-to-alist
!       (list (cons (selected-window) help-return-method))))
! 
  
  ;; Grokking cross-reference information in doc strings and
  ;; hyperlinking it.
--- 189,205 ----
  
  ;;;###autoload
  (defun help-mode-finish ()
+   (let ((entry (assq (selected-window) view-return-to-alist)))
+       (if entry (setcdr entry (cons (selected-window)
+                                     help-return-method))
+         (setq view-return-to-alist
+               (cons (cons (selected-window) help-return-method)
+                     view-return-to-alist))))
    (when (eq major-mode 'help-mode)
      ;; View mode's read-only status of existing *Help* buffer is lost
      ;; by with-output-to-temp-buffer.
      (toggle-read-only 1)
!     (help-make-xrefs (current-buffer))))
  
  ;; Grokking cross-reference information in doc strings and
  ;; hyperlinking it.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]