Re: [PATCH] emacs should use GtkFileChooser widget

[Jan D.]

> Yes I noticed this too but I don't follow your argumentation that it's
> bad dialog design. IMO the internal emacs API is insufficient here.
> There should be a way to distinguish between opening and saving and
> mustmatch_p simply is not enough information here.

Well, you could argue that, and in fact this seems to be the attitude
of most Gnome/GTK developers.  The applications needs fixing, not the
toolkit.  It is a bit like you said earlier, "you are simply missing 
icons".
For most users the correct statement is "GtkFileChooser is missing icons
and this embarrasing bug has not been fixed until GTK 2.4.4".

If GTK is supposed to be a toolkit, it should be of general use, and not
force the application that uses it to change IMHO.  If it does that, it
really is not a general purpose toolkit.

> > Also, I can't get rid of the annoying
> >
> > (emacs:21803): Gtk-CRITICAL **: file gtksettings.c: line 447
> > (gtk_settings_get_for_screen): assertion `GDK_IS_SCREEN (screen)'
> > failed
> >
> > (emacs:21803): GLib-GObject-WARNING **: invalid (NULL) pointer 
> > instance
> >
> > (emacs:21803): GLib-GObject-CRITICAL **: file gsignal.c: line 1726
> > (g_signal_handler_disconnect): assertion `G_TYPE_CHECK_INSTANCE
> > (instance)' failed
> >
> > that GTK writes everytime the dialog is displayed.  I'm sure there
> > is a GTK bug in there somewhere, but I have put off finding a
> > workaround until the next Emacs release.
>
> I can't reproduce this problem here. What version of GTK+ are you 
> using?

Happens in both 2.4.1 and 2.4.4.  It is a timing thing, if I step in the
debugger it does not happen.

        Jan D.