make bootstrap fails due to grep autoload

[Daniel Pfeiffer]

Hi,

somebody has recently plastered autoloads all over grep.el, even for internal
defvars!!!  I find this comment which I don't understand:

;;; This doesn't work:
;;;      ###autoload (autoload 'grep-mode "grep" nil t)
;;; The ostensibly correct result is nonetheless opaque to the accounting
;;; done in `generate-file-autoloads'; in loaddefs.el, the generated elisp is
;;; correct but the generated header comment for grep.el lacks `grep-mode'.
;;; This approach also doesn't help other users of `define-compilation-mode'
;;; who wish to autoload.
;;;
;;; Better to extend autoload.el to grok `define-compilation-mode'.

;;;###autoload
(define-compilation-mode grep-mode "Grep"
  ...

The result in loaddefs.el of this autoload is:

(define-compilation-mode grep-mode "Grep" "Sets `grep-last-buffer' and
`compilation-window-height'." (setq grep-last-buffer (current-buffer)) (set
(make-local-variable (quote compilation-error-face)) grep-hit-face) (set
(make-local-variable (quote compilation-error-regexp-alist))
grep-regexp-alist))

This would only work if compile.el were loaded (or define-compilation-mode
autoloadable, which would still result in it being loaded at this point.)  I
don't think that's desirable, because many Emacs users may never need this
library.  Anyways, ./temacs --batch --load loadup bootstrap fails on this:

Loading loaddefs.el (source)...
Symbol's function definition is void: define-compilation-mode
make[1]: *** [bootstrap-emacs] Error 255
make[1]: Leaving directory `/home/pfeiffer/.emacs.d/cvs/src'

coralament / best Grötens / liebe Grüße / best regards / elkorajn salutojn
Daniel Pfeiffer

-- 
lerne / learn / apprends / lär dig / ucz się    Esperanto:
                              http://lernu.net/