emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

find-face is incompatible with XEmacs version


From: Glenn Morris
Subject: find-face is incompatible with XEmacs version
Date: Thu, 06 Jan 2005 15:05:57 +0000
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

The new function find-face is incompatible with the XEmacs version,
and therefore breaks existing package code that tries to handle both
Emacs flavours.

The GNU Emacs version throws an error for an unknown face:

(find-face 'made-up-face)

whereas the XEmacs version simply returns nil. This breaks code such
as the following (from vm-startup.el):

(if (if (fboundp 'find-face)
        (find-face 'vm-monochrome-image)
      (facep 'vm-monochrome-image))
    nil
  (make-face 'vm-monochrome-image)
  (set-face-background 'vm-monochrome-image "white")
  (set-face-foreground 'vm-monochrome-image "black"))





reply via email to

[Prev in Thread] Current Thread [Next in Thread]