emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: w32 build fails with mingw runtime 3.6


From: Alejandro López-Valencia
Subject: Re: w32 build fails with mingw runtime 3.6
Date: Thu, 13 Jan 2005 09:02:06 -0500
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041206 Thunderbird/1.0 Mnenhy/0.6.0.104

On 13/01/2005 08:32 a.m., Kim F. Storm wrote:
Alejandro López-Valencia <address@hidden> writes:


Mingw Runtime 3.6 provides definitions for S_ISLNK, _S_ISLNK, S_IFLNK,
_S_IFLNK and _lstat. Most of these definitions are non-functional, and
break fileio.c.

I am attaching a diff with the modifications I used to build CVS HEAD as
of January 12. I'm not sure it is the proper solution to the problem,
though.



-#ifdef S_ISLNK
+#if defined(S_ISLNK) && !defined(__MINGW32__)


It would be more consitent with emacs coding practice if you put a
define like this in the relevant src/s/???.h header file:

#if defined(__MINGW32__)
#define BROKEN_S_ISLNK 1
#endif


and then use tests like this:


+#if defined(S_ISLNK) && !defined(BROKEN_S_ISLNK)

Reason why I said, I wasn't sure mine was a proper solution... :-)

I'll send a proper patch later today.


--
Alejandro López-Valencia         <http://dradul.tripod.com/>

Lo que Natura non da, Salamanca non presta.
                                Francisco Quevedo y Villegas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]