Re: gdb emacs reporting 'Function "x_error_quitter" not defined' [includes PATCH]

[Eli Zaretskii]

> From: "Andrew M. Scott" <address@hidden>
> Date: Thu, 27 Jan 2005 13:44:40 -0700
> Cc: address@hidden, address@hidden
> 
> gcc -c -D_BSD_SOURCE   -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. 
> -I/stor/garray/src/savannah/emacs/src -D_BSD_SOURCE 
> -I/usr/intel/pkgs/X11/R6.7.0/include -g -O2 
> /stor/garray/src/savannah/emacs/src/xterm.c
> /stor/garray/src/savannah/emacs/src/xterm.c:7794: error: conflicting types 
> for 'x_error_quitter'
> /stor/garray/src/savannah/emacs/src/xterm.c:7780: error: previous implicit 
> declaration of 'x_error_quitter' was here
> gmake[1]: *** [xterm.o] Error 1
> 
> 2. If I apply the xterm.c patch (below) posted by Gary Lawrence Murphy to 
> gnu.emacs.bug on Jan 27, 2005
>    then the x_error_quitter breakpoint works correctly on *both* gcc 3.3.2 
> *and* 3.4.2 builds
>    of CVS Emacs-21.3.50 under gdb-6.3.

A better change was already committed to CVS (by Stefan): it puts a
prototype of x_error_quitter before it is used.

P.S. I never liked the new GCC behavior whereby it whines about
non-bottom-up code layout in programs.  It could be TRT if I compile
with -ansi, but not by default.  Alas, it seems like the attitude
among GCC developers is the more warning/error messages the better.