Re: Default :group in lisp/emacs-lisp/easy-mmode.el.

[Lute Kamstra]

Luc Teirlinck <address@hidden> writes:

> Lute Kamstra wrote:
>
>    All these things apply just as well to a :group value you specify
>    explicitly.  I think it's enough (and a good thing) that the user of
>    define-minor-mode knows that :group defaults and to what.
>
> The docstring should at least point out that this group might very
> well be bogus.

Ok, I'll add a warning.  BTW, doesn't defcustom use custom-current-group
if the specified :group doesn't exist?

>>From my previous message:
>
>    I believe that what should be emphatically documented in the
>    docstring of define-minor-mode and all other places where
>    define-minor-mode is documented is that an explicit :group should
>    *always* be given.
>
> On second thought this might not be 100 percent universal.  It is
> possible that in some cases the (global) minor mode should not have
> a defcustom to begin with, because enabling it permanently makes no
> sense.  Maybe the hook variable should nevertheless still have a
> defcustom with a real group in this case.  define-minor-mode does
> not seem to provide for these possibilities.

A defcustom for the mode variable doesn't really hurt if it isn't
used, does it?

> I believe that define-minor-mode and maybe define-generic-mode are
> trying to automate things that can not be automated.

define-generic-mode only creates a defcustom for the mode hook.

Lute.