M-x flymake-mode to toggle it on doesn't start checking.

[asc]

Setting a buffer to flymake-mode or toggling flymake-mode off and on (with M-x
flymake-mode), I couldn't get it to check the buffer on a buffer change or
after some delay.

I made this change and it seemed to work better:

        * flymake.el (flymake-mode-on): removed 'when (not
        flymake-mode)' - otherwise never ran the set up stuff.

The way it reads seems right (turn it on when it's not on), but when I ran the
debugger and did M-x flymake-mode (with flymake mode off) it arrived at
function flymake-mode-on with the variable flymake-mode set 'on'.  This
matches the define-minor-mode description in the Elisp manual.

 - Macro: define-minor-mode mode doc [init-value [lighter [keymap]]]
     ... It also defines a variable named
     MODE, which is set to `t' or `nil' by enabling or disabling the
     mode. ...



***************
*** 1465,1471 ****
  ;;;###autoload
  (defun flymake-mode-on ()
    "Turn flymake mode on."
!   (when (not flymake-mode)
      (make-local-variable 'after-change-functions)
      (setq after-change-functions (cons 'flymake-after-change-function
after-change-functions))
      (add-hook 'after-save-hook 'flymake-after-save-hook)
--- 1466,1472 ----
  ;;;###autoload
  (defun flymake-mode-on ()
    "Turn flymake mode on."
! ;;  (when (not flymake-mode)
      (make-local-variable 'after-change-functions)
      (setq after-change-functions (cons 'flymake-after-change-function
after-change-functions))
      (add-hook 'after-save-hook 'flymake-after-save-hook)
***************
*** 1480,1486 ****
      (setq flymake-mode t)
      (flymake-log 1 "flymake mode turned ON for buffer %s" (buffer-name
(current-buffer)))
      (when flymake-start-syntax-check-on-find-file
!       (flymake-start-syntax-check-for-current-buffer)))) ; will be started by
on-load hook

  ;;;###autoload
  (defun flymake-mode-off ()
--- 1481,1489 ----
      (setq flymake-mode t)
      (flymake-log 1 "flymake mode turned ON for buffer %s" (buffer-name
(current-buffer)))
      (when flymake-start-syntax-check-on-find-file
!       (flymake-start-syntax-check-for-current-buffer))
! ;;)
! ) ; will be started by on-load hook

  ;;;###autoload
  (defun flymake-mode-off ()



In GNU Emacs 22.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.2.4)
 of 2005-05-19 on es3020g
Distributor `The XFree86 Project, Inc', version 11.0.40300000
configured using `configure '--exec-prefix=/net/sf05/data2/users/x/local2/Linux'
'--prefix=/net/sf05/data2/users/x/local2' '--with-x-toolkit=gtk''

Important settings:
  value of $LC_ALL: C
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Change Log

Minor modes in effect:
  auto-insert-mode: t
  global-auto-revert-mode: t
  which-function-mode: t
  msb-mode: t
  show-paren-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  tooltip-mode: t
  auto-compression-mode: t
  menu-bar-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  line-number-mode: t
  next-error-follow-minor-mode:  Fol
  view-mode: t

Recent input:
C-s <help-echo> <help-echo> <help-echo> <return> C-x
d <return> C-x d p r o <tab> <return> <next> <next>
<next> <prior> C-h f f l y m a k e <tab> <tab> m o
<tab> <return> <help-echo> <help-echo> <help-echo>
<down-mouse-2> <mouse-2> C-x d <return> <next> <prior>
<prior> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> v <down> <down> <help-echo> <help-echo> <down-mouse-1>
<mouse-movement> <mouse-movement> <drag-mouse-1> <escape>
w <escape> x b u <tab> <backspace> <backspace> C-g
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <menu-bar> <help-menu> <re
port-emacs-bug>

Recent messages:
Mark saved where search started [2 times]
Making completion list...
C-M-v to scroll the help.
file /net/sf05/data2/users/x/local2/share/emacs/site-lisp/flymake.el, init=nil
call-interactively: Beginning of buffer
file /net/sf05/data2/users/x/local2/share/emacs/site-lisp/ChangeLog, init=nil
View mode: type C-h for help, h for commands, q to quit.
Making completion list...
Quit
Loading emacsbug...done