Re: insert-buffer vs insert-buffer-substring

[Richard M. Stallman]

    I just fixed a bug in info.el caused by replacing `insert-buffer' with
    `insert-buffer-substring'.  Instead of `(insert-buffer-substring buffer)',

Sorry.  I didn't see that the change caused a problem.

    I added the following construct:

      (goto-char (prog1 (point) (insert-buffer-substring buffer)))

That is rather idiomatic.  I would prefer

    (let ((foo (point)))
      (insert-buffer-substring buffer)
      (goto-char (point)))

However, for this particular job, you can do

    (save-excursion
      (insert-buffer-substring buffer))