Re: loaddefs.el on Windows incomplete

[Ralf Angeli]

* Ralf Angeli (2005-07-08) writes:

> * Ralf Angeli (2005-07-07) writes:
>
>> Using this for bootstrapping with `mingw32-make bootstrap' from a DOS
>> prompt in the nt/ directory I get the following error:
> [...]
>> Opening output file: invalid argument, 
>> d:/software/windows/unix/src/emacs/lisp/D;C:Programmemsys☺.0 
>> oftwarewindowsunix rc←macslisploaddefs.el
>> mingw32-make[1]: *** [autoloads] Error -1
>> mingw32-make[1]: Leaving directory `D:/software/windows/unix/src/emacs/lisp'
>> mingw32-make: *** [bootstrap-gmake] Error 2
>
> Okay, with the following patch (thanks, David, for reminding me of the
> technique) I can build Emacs under Windows using mingw32-make (MinGW
> 4.1.0) with MSYS' (1.0.10) sh.exe either present or not.
>
> 2005-07-08  Ralf Angeli  <address@hidden>
>
>       * makefile.w32-in (autoloads): Do not let autoload file name be
>       mangled by the shell.

I'd like to followup on this because until now nothing has happened
and I've been bitten by this problem again, namely the build process
failed to update the autoloads but instead of aborting with an error,
it completed "successfully".  This happens with MSYS' `make' and `sh'.

The patch mentioned above allowed me to build successfully, i.e. with
updated autoloads, with `mingw32-make' and MSYS' `sh'.  After the
inclusion of MH-E a similar statement like the one for building the
autoloads for Emacs in general is used for MH-E as well.  That means
the patch mentioned above does not work anymore.  Below you can find
an updated version.

I'd very much appreciate it if this patch were applied or the build
process be aborted if the autoloads cannot be updated.

Index: makefile.w32-in
===================================================================
RCS file: /sources/emacs/emacs/lisp/makefile.w32-in,v
retrieving revision 1.53
diff -u -r1.53 makefile.w32-in
--- makefile.w32-in     17 Dec 2005 17:27:35 -0000      1.53
+++ makefile.w32-in     18 Dec 2005 15:47:21 -0000
@@ -158,8 +158,14 @@
 autoloads: $(lisp)/loaddefs.el doit
        @echo Directories: . $(WINS)
        $(emacs) -l autoload \
-               --eval $(ARGQUOTE)(setq find-file-hook nil 
find-file-suppress-same-file-warnings t generated-autoload-file 
$(DQUOTE)$(lisp)/loaddefs.el$(DQUOTE))$(ARGQUOTE) \
-               -f batch-update-autoloads . $(WINS)
+                --eval $(ARGQUOTE)(let ((find-file-hook nil) \
+                       (find-file-suppress-same-file-warnings t) \
+                       (generated-autoload-file \
+                        (expand-file-name (pop command-line-args-left)))) \
+                       (mapcar (function update-directory-autoloads) \
+                               command-line-args-left) \
+                       (save-buffers-kill-emacs t))$(ARGQUOTE) \
+                "$(lisp)/loaddefs.el" $(lisp) $(WINS)
 
 $(lisp)/subdirs.el:
        $(MAKE) $(MFLAGS) update-subdirs
@@ -310,11 +316,16 @@
        rm pre-mh-loaddefs.el-$(SHELLTYPE)
        $(EMACS) $(EMACSOPT) \
           -l autoload \
-          --eval "(setq generate-autoload-cookie \";;;###mh-autoload\")" \
-          --eval "(setq generated-autoload-file 
\"$(lisp)/mh-e/mh-loaddefs.el\")" \
-          --eval "(setq find-file-suppress-same-file-warnings t)" \
-          --eval "(setq make-backup-files nil)" \
-          -f batch-update-autoloads $(lisp)/mh-e
+          --eval $(ARGQUOTE)(let ((find-file-hook nil) \
+                  (find-file-suppress-same-file-warnings t) \
+                  (make-backup-files nil) \
+                  (generate-autoload-cookie ";;;###mh-autoload") \
+                  (generated-autoload-file \
+                   (expand-file-name (pop command-line-args-left)))) \
+                  (mapcar (function update-directory-autoloads) \
+                          command-line-args-left) \
+                  (save-buffers-kill-emacs t))$(ARGQUOTE) \
+          "$(lisp)/mh-e/mh-loaddefs.el" $(lisp)/mh-e
 
 pre-mh-loaddefs.el-SH:
        echo ";;; mh-loaddefs.el --- automatically extracted autoloads" > $@

-- 
Ralf