[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: describe-char

From: Juri Linkov
Subject: Re: describe-char
Date: Fri, 23 Dec 2005 22:43:14 +0200
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

>> +    (setq help-xref-stack-item (list 'help-insert-string (buffer-string)))
> This is wrong.  There are functions like help-setup-xref to do this job.

The function help-setup-xref is already used in describe-char as

    (help-setup-xref nil (interactive-p))

It is called before the old contents of the help buffer is replaced with
the output of `describe-char'.  This is necessary to record the previous
position of point.  But since at this moment the help buffer doesn't contain
the new output of `describe-char', we should use nil for the first
argument `item' of the function `help-setup-xref' here, and should set
`help-xref-stack-item' explicitly later when the help buffer is ready.

> Don't access help-xref-stack-item directly unless you really have to, in
> which case you should justify it with a clear comment describing
> the problem.

Unless you propose a better solution, I will add a comment.

Juri Linkov

reply via email to

[Prev in Thread] Current Thread [Next in Thread]