[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: In info: Wrong type argument: stringp, nil

From: Richard M. Stallman
Subject: Re: In info: Wrong type argument: stringp, nil
Date: Fri, 06 Jan 2006 23:23:31 -0500

    -    (if (zerop (buffer-size))
    +    (if (and (zerop (buffer-size))
    +        (null Info-history))
    +   ;; If we just created the Info buffer, go to the directory.

    A new condition `(null Info-history)' doesn't fix a bug, but with some
    user configuration it creates an empty Info buffer.

In those situations, I think the empty Info buffer is correct.
That can only happen if the buffer has been emptied by some
Info command--such as, visiting a whole file which is empty.

In what cases did you see an empty buffer?

    I can't produce any problem now, so we could either wait for more bug
    reports or at least restore the following change:

    @@ -726,8 +729,7 @@
            (pline        (count-lines (point-min) (line-beginning-position)))
            (wline        (count-lines (point-min) (window-start)))
            (old-history  Info-history)
    -   (new-history (and Info-current-file
    -                     (list Info-current-file Info-current-node (point)))))
    +   (new-history  (list Info-current-file Info-current-node (point))))
         (kill-buffer (current-buffer))
         (Info-find-node filename nodename)
         (setq Info-history old-history)

    This change most likely can produce a bug because a condition below in
    the same function tests the value of `new-history' as:

          ;; only add to the history when coming from a different file+node
          (if new-history
              (setq Info-history (cons new-history Info-history))))))

If you see a bug in that, please fix it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]