Re: address@hidden: arc-mode fails for some nested archives (patch included)]

[Eli Zaretskii]

> To: address@hidden
> From: Joe Wells <address@hidden>
> Date: Sat, 28 Jan 2006 21:33:17 +0000
> 
> Suppose you have a .zip file which contains a member named:
> 
>   abc/def.jar
> 
> Suppose abc/def.jar further contains more files.  Then when you try to
> visit one of the files inside abc/def.jar using the "f" key (bound to
> archive-extract), it will fail and you will get an error message like
> this:
> 
>   Opening output file: no such file or directory, 
> /tmp/archive.tmp4066KXk/abc/def.jar
> 
> The problem lies in the function archive-maybe-copy.  It contains code
> to try to make sure the necessary temporary directories exist, but the
> code is completely messed up and nonsensical.
> 
> Here is a patch that fixes the problem:

Thanks.

There's nothing ``nonsensical'' in what archive-maybe-copy did: it just
used the wrong variable to do it, `archive' instead of `archive-name'.
The former is an absolute file name, so it is clearly wrong to try to
create it under `archive-tmpdir'.

However, your code was more compact and more tolerant to future
changes in archive-unique-fname, so I installed it instead of fixing
the current code.

(As an aside, perhaps in the future you could choose kinder wording,
especially since you yourself are sensitive to anything that sounds
like an offense.)

Thanks again.