Re: Multiple runs of menu-bar-update-hook

[Richard Stallman]

    Is this the kind of debugging you wanted - does it help?

It is the right kind, and it gives some useful info.

Now the question is, since it ran the hook inside update_menu_bar,
why did it run the hook again in set_frame_menubar?
Something near the start of that function must be setting deep_p
to nonzero.  Can you see what it is, and why?

    Earlier I made the point that Qmenu_bar_update_hook is already run when I
    mouse-1 on the menu bar.  I suggested that it seemed reasonable to run it at
    that time and other specific times only (such as when switching buffers or
    windows), rather than during redisplay.  No-one came out and said it was mad
    or stupid, so would dealing with the menu bar that way be better than
    dealing with it during redisplay and fixing the existing code?

I don't like it.  It makes new assumptions about what conditions
menu-bar-update-hook cares about.