Re: ldap-search-internal ignores auth type setting

[Chong Yidong]

Toby Allsopp <address@hidden> writes:

> The variable ldap-host-parameters-alist allows you to choose a value
> for the authentication type to use, but this value is ignored by
> ldap-search-internal.
>
> The attached patch makes the 'simple' choice work, which is good
> enough for me and better then nothing.

Looks OK to me; I've checked it in.

> *** ldap.el   2006-09-04 11:04:22.000000000 +1200
> --- ldap-patched.el   2006-09-04 11:12:23.000000000 +1200
> ***************
> *** 493,498 ****
> --- 493,499 ----
>     `base' is the base for the search as described in RFC 1779.
>     `scope' is one of the three symbols `sub', `base' or `one'.
>     `binddn' is the distinguished name of the user to bind as (in RFC 1779 
> syntax).
> +   `auth' is one of the symbols `simple', `krbv41' or `krbv42'
>     `passwd' is the password to use for simple authentication.
>     `deref' is one of the symbols `never', `always', `search' or `find'.
>     `timelimit' is the timeout limit for the connection in seconds.
> ***************
> *** 512,517 ****
> --- 513,519 ----
>                 ldap-default-base))
>       (scope (plist-get search-plist 'scope))
>       (binddn (plist-get search-plist 'binddn))
> +         (auth (plist-get search-plist 'auth))
>       (passwd (plist-get search-plist 'passwd))
>       (deref (plist-get search-plist 'deref))
>       (timelimit (plist-get search-plist 'timelimit))
> ***************
> *** 541,546 ****
> --- 543,551 ----
>         (if (and binddn
>              (not (equal "" binddn)))
>         (setq arglist (nconc arglist (list (format "-D%s" binddn)))))
> +       (if (and auth
> +            (equal 'simple auth))
> +       (setq arglist (nconc arglist (list "-x"))))
>         (if (and passwd
>              (not (equal "" passwd)))
>         (setq arglist (nconc arglist (list (format "-w%s" passwd)))))
> _______________________________________________
> emacs-pretest-bug mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug