Re: emacsclient horribly broken

[Kim F. Storm]

"Juanma Barranquero" <address@hidden> writes:

> On 10/31/06, Jan Djärv <address@hidden> wrote:
>
>> We should use O_NONBLOCK.  It is more widespread on Unix nowdays, and FIONBIO
>> does not have exactly the same sematics.
>
> It is compatible with Windows?
>
>> How do we hande this elsewhere in Emacs?
>
> src/process.c, src/sysdep.c and src/w32.c already use FIONBIO.

Please study the code a little closer:

process.c and sysdep.c use O_NONBLOCK / O_NDELAY in general for
non-blocking sockets.

They use FIONBIO only for very specific platforms, and typically
only in relation to PTYs.

So O_NONBLOCK is the right choice for the generic code.

However, w32.c seems to use FIONBIO consistently to handle "O_NDELAY".
I'm not familiar with the code to say what's going on.

-- 
Kim F. Storm <address@hidden> http://www.cua.dk