emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tutorial: "but you can use instead"


From: Lennart Borgman (gmail)
Subject: Re: tutorial: "but you can use instead"
Date: Tue, 02 Jan 2007 19:28:54 +0100
User-agent: Thunderbird 1.5.0.9 (Windows/20061207)

Chris Moore wrote:
I have bound M-k to bury-buffer.

Typing C-h t to see the tutorial shows me these 2 lines (and lots of
other, expected text):

        M-k          Kill to the end of the current sentence
  ** M-k has been rebound, but you can use  instead [More] **

The bug I'm reporting is that "you can use  instead" doesn't mean
anything.  It looks like an empty string has been inserted there.

kill-sentence isn't bound anywhere.  Clicking the '[More]' link shows
me:

Here is a patch for that. It also takes care of the problem when a key was rebound to nil:

Index: tutorial.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/tutorial.el,v
retrieving revision 1.9
diff -u -r1.9 tutorial.el
--- tutorial.el    22 Dec 2006 15:24:10 -0000    1.9
+++ tutorial.el    2 Jan 2007 18:27:19 -0000
@@ -446,7 +446,8 @@
            (cond ((eq key-fun def-fun)
                   ;; No rebinding, return t
                   t)
-                  ((eq key-fun (command-remapping def-fun))
+                  ((and key-fun
+            (eq key-fun (command-remapping def-fun)))
                   ;; Just a remapping, return t
                   t)
                  ;; cua-mode specials:
@@ -571,6 +572,8 @@
          (where   (nth 3 ck))
          s1 s2 help-string)
         (unless (string= where "Same key")
+           (when (string= where "")
+         (setq where (format "M-x %s" def-fun)))
           (setq tutorial--point-after-chkeys (point-marker)
             s1 (get-lang-string tutorial--lang 'tut-chgdkey)
             s2 (get-lang-string tutorial--lang 'tut-chgdkey2)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]