[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: No refresh of buffer before popup-menu

From: Lennart Borgman (gmail)
Subject: Re: No refresh of buffer before popup-menu
Date: Thu, 22 Feb 2007 23:40:37 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20061207 Thunderbird/ Mnenhy/

Lennart Borgman (gmail) wrote:
Jason Rumney wrote:
Lennart Borgman (gmail) wrote:
Do you mean that the second menu is created before returning from the first w32_menu_show. It does not look so to me, but I might be misreading the code. Is not "selection" that is returned from the first w32_menu_show what is used to decide to do?
w32_free_menu_strings is also called from elsewhere, to handle the case where the menus are cancelled by pressing ESC or clicking outside the menu. This is what causes the problems, as it is not easy to figure out whether old strings need to be cleaned up. The creation of the second menu has fooled the cleanup code into thinking that w32_free_menu_strings has not yet been called at the point where Windows has finished destroying the menu (actually after a delay, because doing so immediately caused problems in the past), so it goes ahead and destroys the second menu's strings, which causes problems if the second menu needs to redraw its owner-drawn strings (the title) again.

Ah, then should not menu_kill_timer be called from within w32_free_menu_strings (or always before that)?

Killed of course, not called.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]