[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch for locate.el when called with prefix arg
From: |
Luc Teirlinck |
Subject: |
Re: patch for locate.el when called with prefix arg |
Date: |
Sun, 22 Apr 2007 23:45:49 -0500 (CDT) |
Miles Bader wrote:
Why are you putting the "prefix inverts sense of locate-prompt-for-command"
logic into the main function body, and not in the (interactive ...) code?
I believe that was already the case before my patch is it not?
It would seem more understandable and useful for non-interactive users if
you just added a "prompt-for-command" argument to the locate function and
put all the grot involving locate-prompt-for-command into the interactive
code.
IOW, (1) add a "prompt-for-command" argument to locate, (2) use that arg
everywhere in the function body where "locate-prompt-for-command" used to be
used, (3) implement the arg toggles global var stuff in the (interactive ...)
code (e.g., (not (eq (not arg) (not locate-prompt-for-command)))).
[I think anytime you find yourself using a function argument called "arg"
with funny semantics intended solely for convenient keyboard use, it's a
hint that maybe you should rethink the function interface.]
I was trying to keep changes as minimal as possible while still fixing
all bugs and misfeature. I thought Chong was about to cut a final
pretest Monday (depending on the place where you live, that may mean
today), so I was hurrying. I do not believe that any of the
programming interface objections you were introduced by the patch I
proposed, or ..,?
Sincerely,
Luc Teirlinck.
- Re: patch for locate.el when called with prefix arg, (continued)
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/22
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/22
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Miles Bader, 2007/04/23
- Re: patch for locate.el when called with prefix arg,
Luc Teirlinck <=
- Re: patch for locate.el when called with prefix arg, Miles Bader, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Miles Bader, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Miles Bader, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Richard Stallman, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Richard Stallman, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Chong Yidong, 2007/04/23