Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars

[Chong Yidong]

Chong Yidong <address@hidden> writes:

> YAMAMOTO Mitsuharu <address@hidden> writes:
>
>>> After looking at it, I realized there was no need to call
>>> x_encode_text in the GTK case.  So I separated the two cases
>>> completely, which should improve things.
>>
>> I'm not so familiar with GTK+, but is the call to XSetWMIconName
>> unnecessary in the GTK+ case?  Previously, it was called in both cases
>> and that was the reason for x_encode_text in the GTK+ case.
>
> I believe this was an oversight.  However, on my Gnome desktop, it
> makes no observable difference.  According to the Xlib specs,
> XSetWMIconName sets the WM_ICON_NAME window property, which is a
> "string that the client wants to be displayed in association with the
> window when it is iconified (for example, in an icon label)".
> However, I see the same iconfied window names for GTK and non-GTK
> builds, both before and after RMS's change.

I looked at the GTK+ sources.  Apparently, if we don't set
WM_ICON_NAME ourselves, gtk_window_set_icon_name sets WM_ICON_NAME for
us.  So I think we are perfectly safe.