Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars

[Chong Yidong]

Richard Stallman <address@hidden> writes:

>     > If my change broke something, then please undo it; but in that case,
>     > please put in whatever GCPROs are needed for x_encode_text.
>
>     The GCPRO you added in x_encode_text was not deleted.
>
> I know that, but we are miscommunicating.  There needs to be a GCPRO
> in x_set_name_internal around the calls to x_encode_text, at least to
> protect the variable encoded_name.  Or else the code needs to be
> rearranged so encoded_name is not used after the calls to
> x_encode_text.

Ah, now I understand what you are saying.  But even if your change had
been left in place, wouldn't these GCPRO would have been needed anyway
(for the case where HAVE_GTK is false)?