[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Changelog mode entry in auto-mode-alist
From: |
Dan Nicolaescu |
Subject: |
Re: Changelog mode entry in auto-mode-alist |
Date: |
Mon, 04 Jun 2007 16:44:58 -0700 |
Chong Yidong <address@hidden> writes:
> The following patch, which was only checked into the trunk, changed
> the change-log-mode entry in auto-mode-alist:
>
> 2007-05-19 Dan Nicolaescu <address@hidden>
>
> * files.el (auto-mode-alist): Change the regexp so that
> ChangeLog.unicode and ChangeLog.multi-tty use change-log-mode.
>
> --- files.el 2007/05/17 01:12:55 1.899
> +++ files.el 2007/05/19 23:44:43 1.900
> @@ -1924,7 +1924,7 @@
> ("\\.[sS]\\'" . asm-mode)
> ("\\.asm\\'" . asm-mode)
> ("[cC]hange\\.?[lL]og?\\'" . change-log-mode)
> - ("[cC]hange[lL]og[-.][0-9]+\\'" . change-log-mode)
> + ("[cC]hange[lL]og[-.][-0-9a-z]+\\'" . change-log-mode)
> ("\\$CHANGE_LOG\\$\\.TXT" . change-log-mode)
> ("\\.scm\\.[0-9]*\\'" . scheme-mode)
> ("\\.[ck]?sh\\'\\|\\.shar\\'\\|/\\.z?profile\\'" . sh-mode)
>
> Is this really desirable? With this change, ChangeLog.sh (for
> instance) opens in change-log-mode rather than shell script mode.
> Maybe we should either revert this change (and use file variables to
> specify the mode for ChangeLog.unicode and similarly-named files), or
> move the change-log-mode entry further down in auto-mode-alist.
File variables are not very good for non-emacs hackers. We can do it
in emacs, but there are other projects that use the
ChangeLog.BRANCH_NAME convention, we should make using the right mode
easier for those projects.
I'd vote for moving the change-log-mode further down in
auto-mode-alist.