Re: [emacs-wiki-discuss] Re: remember-buffer

[Tom Ed White]

At Wed, 19 Jan 2005 22:57:06 +0900,
Sacha Chua wrote:
> 
> address@hidden writes:
> 
> > The remember-buffer function creates a note in the plan page, but the
> > note ends up being empty, without the contents of the buffer being 
> > transferred.
> > Is this a glitch, or do I need to configure something?
> 
> Right, this is a glitch. Sorry about it. The following patch fixes it, or
> you can just get the one in the dev archive... =)
> 
> --- orig/remember-planner.el
> +++ mod/remember-planner.el
> @@ -72,9 +72,6 @@
>              (when (or (not planner-use-day-pages)
>                        remember-planner-xref-p)
>                (planner-read-name (planner-file-alist))))))
> -  (set-buffer (get-buffer-create remember-buffer))
> -  (goto-char (point-max))
> -  (unless (bolp) (insert "\n")) ; Trailing newline
>    (let ((text (buffer-string))
>          start)
>      (save-window-excursion
> @@ -83,6 +80,7 @@
>          (planner-create-note page))
>        (setq start (line-beginning-position))
>        (insert text)
> +      (unless (bolp) (insert "\n")) ;; trailing newline
>        (save-restriction
>          (narrow-to-region start (point))
>          (mapcar
> 
> 
> If it works, please mail me so that I can merge it into stable. Thanks
> for reporting the bug!
> -- 
> Sacha Chua <address@hidden> - open source geekette
> http://sacha.free.net.ph/ - PGP Key ID: 0xE7FDF77C
> interests: emacs, gnu/linux, personal information management, CS ed
> applying as a Debian new maintainer | looking for a grad school
> 
> 
> _______________________________________________
> emacs-wiki-discuss mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/emacs-wiki-discuss

Sacha,

Thanks for the patch! Here's what I got from the patch application:


Hunk #1 FAILED at 72.
Hunk #2 succeeded at 70 with fuzz 1 (offset -10 lines).
1 out of 2 hunks FAILED -- saving rejects to file mod/remember-planner.el.rej

And here's the content of remember-planner.el.rej:


***************
*** 72,80 ****
              (when (or (not planner-use-day-pages)
                        remember-planner-xref-p)
                (planner-read-name (planner-file-alist))))))
-   (set-buffer (get-buffer-create remember-buffer))
-   (goto-char (point-max))
-   (unless (bolp) (insert "\n")) ; Trailing newline
    (let ((text (buffer-string))
          start)
      (save-window-excursion
--- 72,77 ----
              (when (or (not planner-use-day-pages)
                        remember-planner-xref-p)
                (planner-read-name (planner-file-alist))))))
    (let ((text (buffer-string))
          start)
      (save-window-excursion

Maybe I messed up the patch application?

Thanks,
Tom Ed