[emacs-wiki-discuss] Re: Bugfix for link escaping in emacs-wiki

[Michael Olson]

Sacha Chua <address@hidden> writes:

> After a few complaints about non-working links on my site, I
> discovered that link-escaping broke the ? and & found in dynamic
> URLs.  The following really short patch fixes it. Mike? =)
>
> --- orig/emacs-wiki-publish.el
> +++ mod/emacs-wiki-publish.el
> @@ -1956,7 +1956,7 @@
>       (save-match-data
>          (cond
>           ((emacs-wiki-wiki-url-p link)
> -          (emacs-wiki-escape-url link))
> +          link)
>           ((or (string-match emacs-wiki-image-regexp link)
>                (string-match emacs-wiki-file-regexp link))
>            link)

Can you give me an example of the scenario that requires this fix?
Would it be sufficient to leave '?' alone in emacs-wiki-escape-url?

-- 
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: anime, Debian, XHTML, wiki, Emacs Lisp
  /` |\ | | | IRC: mwolson on freenode.net: #hcoop, #muse, #pulug
 |_] | \| |_| Jabber: mwolson_at_hcoop.net

pgpDaAtFAwxFd.pgp
Description: PGP signature