emms-help
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[emms-help] Miscellaneous patches


From: Daniel Brockman
Subject: [emms-help] Miscellaneous patches
Date: Wed, 18 May 2005 17:19:20 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

This avoids warnings the first time you compile emms-auto.el:

Index: Makefile
===================================================================
RCS file: /cvsroot/emms/emms/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile    21 Feb 2004 03:35:54 -0000      1.4
+++ Makefile    18 May 2005 15:07:45 -0000
@@ -12,7 +12,7 @@
 
 emms-auto.el: emms-auto.in $(SOURCE)
        cp emms-auto.in emms-auto.el
-       -rm emms-auto.elc
+       -rm -f emms-auto.elc
        $(EMACS) --no-init-file --no-site-file -batch \
                -l emms-maint.el \
                -l emms-auto.el \
When you type M-x emms-play-directory RET /media/some/album RET, the
first song immediately starts playing --- before its info has had a
chance to load.  This results in the mode line displaying an ugly file
name for the first file, but a nice-looking title for the others.
This simple fix just loads the info for the first file synchronously:

Index: emms-info-later-do.el
===================================================================
RCS file: /cvsroot/emms/emms/emms-info-later-do.el,v
retrieving revision 1.3
diff -u -r1.3 emms-info-later-do.el
--- emms-info-later-do.el       3 Apr 2004 11:24:28 -0000       1.3
+++ emms-info-later-do.el       18 May 2005 15:07:45 -0000
@@ -150,11 +150,11 @@
                           :artist "" :note ""
                           :file (emms-track-name curtrack)))))
       (setq idx (1+ idx))))
-  ;; Queue loading the info for each track, if any tracks need to be
-  ;; loaded.
+  ;; Queue loading the info for each track, if any tracks need to be loaded.
   (when emms-info-later-do-track-queue
-    ;; start the process!
-    (later-do 'emms-info-later-do-process)))
+    ;; Process the first item synchronously to avoid having it displayed in
+    ;; the mode line before its meta-data has been fetched.
+    (emms-info-later-do-process)))
 
 (provide 'emms-info-later-do)
 ;;; emms-info-later-do.el ends here
These just fix a couple of dependencies:

Index: emms-pbi.el
===================================================================
RCS file: /cvsroot/emms/emms/emms-pbi.el,v
retrieving revision 1.32
diff -u -r1.32 emms-pbi.el
--- emms-pbi.el 24 Dec 2004 09:33:32 -0000      1.32
+++ emms-pbi.el 18 May 2005 15:07:45 -0000
@@ -80,6 +80,7 @@
 ;;; Code:
 
 (require 'emms)
+(require 'cl)
 
 (defvar emms-pbi-version "0.2 $Revision: 1.32 $"
   "EMMS pbi version string.")
@@ -360,7 +361,7 @@
             (emms-playlist-get idx))))
 
 ;; Major-mode for the playlist-buffer
-(define-derived-mode  emms-pbi-mode fundamental-mode "EMMS playlist"
+(define-derived-mode emms-pbi-mode fundamental-mode "EMMS playlist"
   (suppress-keymap emms-pbi-mode-map t)
   (define-key emms-pbi-mode-map (kbd "n")         'emms-next)
   (define-key emms-pbi-mode-map (kbd "p")         'emms-previous)
Index: emms-tageditor.el
===================================================================
RCS file: /cvsroot/emms/emms/emms-tageditor.el,v
retrieving revision 1.12
diff -u -r1.12 emms-tageditor.el
--- emms-tageditor.el   24 Mar 2004 16:56:02 -0000      1.12
+++ emms-tageditor.el   18 May 2005 15:07:47 -0000
@@ -54,7 +54,10 @@
 
 (require 'emms)
 (require 'emms-info)
+(require 'emms-pbi)
+(require 'emms-pbi-mark)
 (require 'widget)
+(require 'wid-edit)
 
 ;; Custom
 (defgroup emms-tageditor nil
This automatically sorts all tracks you add to the playlist:

Index: emms.el
===================================================================
RCS file: /cvsroot/emms/emms/emms.el,v
retrieving revision 1.37
diff -u -r1.37 emms.el
--- emms.el     25 Apr 2005 22:13:00 -0000      1.37
+++ emms.el     18 May 2005 15:07:47 -0000
@@ -398,7 +398,7 @@
   (let ((idx (or idx (length emms-playlist))))
     (emms-playlist-set-playlist
      (vconcat (substring emms-playlist 0 idx)
-              seq
+              (emms-playlist-sort-vector seq)
               (substring emms-playlist idx)))))
 
 (defun emms-playlist-remove (idx)
@@ -478,7 +478,7 @@
 
 (defun emms-source-play (lis)
   "Play the tracks in LIS."
-  (let ((new (vconcat lis)))
+  (let ((new (emms-playlist-sort-vector (vconcat lis))))
     (when (zerop (length new))
       (error "No tracks found"))
     (emms-stop)
-- 
Daniel Brockman <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]