[emms-help] Re: Packaging as RPM and Makefile

[Tim Landscheidt]

Lucas Bonnet <address@hidden> wrote:

>>   As 3.0 is probably no longer maintained, the first patch
>> may not be so interesting, but I noticed that HEAD's Make-
>> file still bears the same characteristics, and before I have
>> a try at packaging a development snapshot, I'd rather settle
>> this first.

>>   Any thoughts?

> I think you'd be better of packaging the HEAD (it should be very
> stable), or maybe waiting until we manage to release a new version,
> sometime in 2010 :)

Well, I'm waiting :-). What issues are there holding up a
formal release?

> [...]
>> diff -urx '*~' emms-3.0.orig/Makefile emms-3.0/Makefile
>> --- emms-3.0.orig/Makefile   2010-05-31 16:20:53.158823378 +0000
>> +++ emms-3.0/Makefile        2010-05-31 16:30:20.670825783 +0000
>> @@ -8,13 +8,11 @@
>>  TARGET=$(patsubst %.el,%.elc,$(SOURCE))
>>  MAN1PAGES=emms-print-metadata.1

>> -DESTDIR=
>> -PREFIX=$(DESTDIR)/usr/local
>> -INFODIR=$(PREFIX)/info
>> -MAN1DIR=$(PREFIX)/share/man/man1
>> -SITELISP=$(PREFIX)/share/emacs/site-lisp/emms
>> +INFODIR=$(DESTDIR)/usr/share/info
>> +MAN1DIR=$(DESTDIR)/usr/share/man/man1
>> +SITELISP=$(DESTDIR)/usr/share/emacs/site-lisp/emms

> Makes sense to me. Can someone else confirm that this won't break
> everything? :)

>> -INSTALLINFO = /usr/sbin/install-info --info-dir=$(INFODIR)
>> +INSTALLINFO = /sbin/install-info --info-dir=$(INFODIR)

> On my Debian, install-info is "/usr/bin/install-info" :(

> Isn't there some sort of standardized way to guess all this stuff ? I
> don't want the Makefile to be distro-specific. Using "$(which install-info)"
> seems too obvious to me to be the proper way.

Of course: automake :-). It's much better than reinventing
the wheel yourself, is part of the FSF biosphere and allows
the user every imaginable freedom to tweak everything.

>>  .PHONY: all install deb-install clean
>>  .PRECIOUS: %.elc %.info %.html
>> @@ -49,6 +47,7 @@
>>      install -m 644 $(ALLSOURCE) $(SITELISP)
>>      install -m 644 $(ALLCOMPILED) $(SITELISP)
>>      install -m 0644 emms.info $(INFODIR)/emms
>> +    test -d $(MAN1DIR) || mkdir -p $(MAN1DIR)

> Shouldn't the -p option silence mkdir when the directory already exists?
> In what case does this generate an error?
> [...]

I just followed the example above ($SITELISP and $INFODIR).
The problem was that $MAN1DIR wasn't created *at all*.

Tim