[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emms-patches] darcs patch: Fix bug of missing lyrics

From: Tassilo Horn
Subject: Re: [Emms-patches] darcs patch: Fix bug of missing lyrics
Date: Fri, 04 Apr 2008 16:52:24 +0200
User-agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (gnu/linux)

William Xu <address@hidden> writes:

>>   Note that sort is a destructive function, so the value should store
>>   back after sort.
> Since `sort' is destructive, emms-lyrics-alist will be modified in
> place.  I don't understand what your patch does.  It looks like doing
> something similar to (setq foo foo).

Ye's right.  Even destructive functions have to be stored back, cause
while sorting the pointer to the lists car are not updated each time.
So you can loose elements if you don't store the returned list.

See this thread for details.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]