[Erc-discuss] erc-nick-default-face and erc-my-nick-face problem

[Peter Keller]

Hello,

I have a problem concerning faces for ERC. I'm using ERC 5.3 and Emacs 24.3.1.

The problem can be demonstrated like this:

1. Put this into a file called psilord-theme.el in /tmp/foobar/

;; BEGIN

(add-to-list 'custom-theme-load-path "/tmp/foobar")

(deftheme psilord "Psilord's Theme - Light on Dark")

(let ((class '((class color) (min-colors 89))))

  (custom-theme-set-faces 'psilord
     `(default ((t
        (:stipple nil :background "Black" :foreground "SteelBlue"
         :inverse-video nil :box nil :strike-through nil :overline nil
         :underline nil :slant normal :weight normal :width semi-condensed
         :family "7x13"))))
     `(erc-action-face ((t (:bold t :weight bold))))
     `(erc-bold-face ((t (:bold t :weight bold))))
     `(erc-dangerous-host-face ((t (:foreground "red"))))
     `(erc-default-face ((t (nil))))
     `(erc-direct-msg-face ((t (:foreground "IndianRed"))))
     `(erc-error-face ((t (:background "Red" :foreground "White"))))
     `(erc-fool-face ((t (:foreground "dim gray"))))
     `(erc-inverse-face ((t (:background "Black" :foreground "White"))))
     `(erc-keyword-face ((t (:bold t :foreground "pale green" :weight bold))))

     `(erc-current-nick-face ((t (:foreground "goldenrod" :weight bold))))
     `(erc-input-face ((t (:foreground "#00ACCC"))))
     `(erc-prompt-face ((t (:bold t :background "black" :foreground "yellow"
:weight bold))))

     `(erc-my-nick-face ((t (:foreground "#DDDDDD" :weight bold))))

     ;; HERE IS THE PROBLEM.....
     `(erc-nick-default-face ((t (:foreground "DarkGrey" :weight bold))))
     ;;`(erc-nick-default-face ((t (nil))))

     `(erc-notice-face ((t (:bold t :foreground "SlateBlue" :weight bold))))
     `(erc-pal-face ((t (:bold t :foreground "Magenta" :weight bold))))
     `(erc-timestamp-face ((t (:bold t :foreground "green" :weight bold))))
     `(erc-underline-face ((t (:underline t))))))

(provide-theme 'psilord)
;; END

2. start emacs like:

emacs -q -l /tmp/foobar/psilord-theme.el

3. Observe the problem:

Start ERC and join an IRC channel and send some messages. You'll
notice that your nick and everyone else's nick are all the same color of
DarkGrey.

At the "HERE IS THE PROBLEM" line, if you comment out the first
erc-nick-default-face specification and enable the second one (and
reload the theme with M-x load-theme RET psilord RET, your nick face on
the messages you send will be the correct #DDDDDD, but then you can't
change the color of the nicks of other people away from the default.

It doesn't matter of the default is commented in or out. It just appears
that erc-nick-default-face simply trumps erc-my-nick-face when the the
erc-nick-default-face isn't (nil).

I believe this to be a bug.

Thank you!

-pete