Re: [fluid-dev] Poly/Mono in 1.1.7?

[Ceresa Jean-Jacques]

Hi, Tom

 

More informations follows:

I confirm that PatchFluidPolyMono-0003 supersedes any others previous patch (i.e xxxxx-0001, xxxxx-0002).

 

The document PATCHFLUIDPOLYMONO-0003.pdf chapter 1.1 page 4 gives full details about

 1) How the patch has be done ? (chapter 1.1.2 page 5)

     From previous Source SourceForge git, not the recent git  upstream 1.1.6 release because the

     first writing was done early at 10/05/2015.

 2) How to apply the patch using tow alternate methods and the reason of this methods ? (chapter 1.1.3 and 1.1.4).

     Of course theses methods was probably only valuable in the context of the Sourceforge v1.06 version.

 

Please note the table chapter 1.1.1 p 5. It gives the full list of impacted files.

The line "src/rvoice/fluid_adsr_env.h" minor bug is the only thing that isn't related to PolyMono patch.

It is a minor correction on the asdr envelope generator behavior . The correction is not perceptible by the ear !!.

To be straigtforward in maintenance, may be this minuscule bug should be in a separate commit.

This will help to feel more confident about any migration on github.

 

Please don't hesitate to ask what you need. For the future discussion i will prefer to refer to the pdf

document because it has a better memory than mine !.

To keep life simple, the simplest way is to ask every things even if you don't intend to read this big pdf ;).

 

I understand the need to change some coding style (polishing). However to keep discussion as simple as possible,

i propose that the neccessary polishing may be done at the last steps. This way, this will be reported in any existing pdf as necessary.

 

I have'nt yet used upstream v1.1.6 so i am'nt yet able to understand possible troubles or conflits but i think it wasn't not to difficult to do at soon i will get a knowledge

of theses troubles and/or conficts . Be aware i am a real git beginner.

 

I'm staying in tune.

 

Regards

jjc

 

> Message du 09/10/17 18:54
> De : "jean-jacques.ceresa" <address@hidden>
> A : "Tom M." <address@hidden>, "FluidSynth mailing list" <address@hidden>
> Copie à :
> Objet : Re: [fluid-dev] Poly/Mono in 1.1.7?
>
>

Hi Tom,

Yes the patch has be done from the v1.06 SourceForge git 1 year ago.

Ben have also apply this patch on a Rpi plateform. I have apply the patch on a Linux Debian too (summer 2016.)

Regards.

-------- Message d'origine --------

De : "Tom M." <address@hidden>

Date : 09/10/2017 17:36 (GMT+01:00)

À : Ceresa Jean-Jacques <address@hidden>, FluidSynth mailing list <address@hidden>

Objet : Re: [fluid-dev] Poly/Mono in 1.1.7?

>

Good to hear.
>
> > so it is higtly dependent of the actual "volume envelope generator" implementation
>
>

You mean volume attenuation via fluid_atten2amp()? This will become user configurable via "synth.volenv", the default stays the same as the current default. Shouldnt have too much influence.
>
> > integrating it in the actual code base is not difficult because it is only an adding that doesn't change any previous FluidSynth functionnality.
>
>

I mainly had merge conflicts in mind here, but we'll see.
>
>

jjc: it seems you were developing this patch against the lastest version from the SourceForge git repo, instead of the upstream 1.1.6 release. Is that correct?

>

Tom
>

>

>

2017-10-09 16:09 GMT+02:00 Ceresa Jean-Jacques <address@hidden>:
>

> Hi, Ben and Tom

>  

> I understand that PolyMono patch be scheduled to the next major release because it is a large adding.

> For this reason , as Tom already know, i intend to help for this.

> Note however that even the patch is large, integrating it in the actual code base is not difficult because it is only an adding that doesn't change any previous FluidSynth functionnality.

> Conversely, the important "legato functionnality" of the patch make use of FluidSynth real-time capabilties, so it is higtly dependent of the actual "volume envelope generator" implementation and i hope seriously this generator will be never modified until the next FluidSynth major release.

> Ben, i hope you will stay always happy using PolyMono patch within your interesting ewi system.

> Cheers.

> jjc

>  

>  

> Message du 08/10/17 10:06
> > De : "Tom M." <address@hidden>
> > A : "FluidSynth mailing list" <address@hidden>
> > Copie à :
> > Objet : Re: [fluid-dev] Poly/Mono in 1.1.7?

> >
> >

No and it wont make it into 1.1.x, too huge. I scheduled this for the next major release. Integrating it into the current code base will be a lot of work and it also needs to be polished. I dont think I can do this my own, so any support on that would be very appreciated:
> >
> > https://github.com/FluidSynth/fluidsynth/issues/158
> >
> >

Tom
> >

> >

2017-10-07 23:49 GMT+02:00 Ben Gonzales <address@hidden>:
> >

Has JJC's Polymono patch been incorporated into the latest 1.1.7?
> >
> > Ben
> >
> >
> > _______________________________________________
> > fluid-dev mailing list
> > address@hidden
> > https://lists.nongnu.org/mailman/listinfo/fluid-dev
> >

> >

>
>
> _______________________________________________
> fluid-dev mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/fluid-dev
>
>

> _______________________________________________
> fluid-dev mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/fluid-dev
>
>

>

_______________________________________________
fluid-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/fluid-dev