Re: [fluid-dev] Calls to fluid_log()

[Carlo Bramini]

Hello!

> Il 9 ottobre 2018 alle 6.46 "Tom M." <address@hidden> ha scritto:
> 
> > In my opinion, it won't be a bad idea to keep the FLUID_LOG macro 
> > everywhere, because it allows to remove the log messages from the sources 
> > quite easily. The user can decide to use an empty macro or an option can be 
> > added to cmake, with something like an ENABLE_LOGGING macro inside 
> > config.h, in a similar manner it has been already done for profiling.
> 
> Why? If logging is not appreciated, one should disable it via the API,

That's true, the user can disable the logging by making NULL callbacks.
I was thinking that if the user want to remove completely the logging, he may 
be also able to do it by changing FLUID_LOG macro. 99% of the work is already 
done, there are just few points to fix, inside the sources that I listed in my 
first message. Since it comes for free, I do not see good reasons for not using 
FLUID_LOG macro also into those missing points. The extra option in cmake was 
just an idea that came out by looking the code, everything can stay as it is 
right now, if you want.

Sincerely.