freepooma-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fix ExpressionTest


From: Richard Guenther
Subject: [PATCH] Fix ExpressionTest
Date: Tue, 24 Aug 2004 14:50:55 +0200 (CEST)

This fixes ExpressionTest by deleting all the strange stuff
from FieldStencilSimple and replacing it with something that
resembles Engine/Stencil.h View1/View2.  In turn we use the
FieldStencilSimple make() that takes a domain and was modeled
after View2 in twoPt() in the test.

Tested with the two FieldStencil tests that are available (though that is
not much...), ExpressionTest (the twoPt stuff) and StencilTests (tests
divVertToCell).

More testcases which show what is expected to work appreciated, because
I don't really know the desired semantics of FieldStencilSimple (and
Stencil) wrt views and domains.

Obviously I don't use Stencils myself.

Ok?

Richard.


2004Aug24  Richard Guenther <address@hidden>

        * src/Engine/Stencil.h: do bounds check only with
        POOMA_BOUNDS_CHECK.
        src/Field/DiffOps/FieldStencil.h: rewrite make(stencil,
        expr), add make(stencil, expr, domain), kill similar
        broken Accumulate stuff, update documentation.
        src/Field/tests/ExpressionTest.cpp: use FieldStencilSimple::make
        with domain argument, don't take view ourselves.

Attachment: p
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]