freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] Time for a new FreeType release


From: Werner LEMBERG
Subject: Re: [ft-devel] Time for a new FreeType release
Date: Tue, 03 Apr 2018 21:58:58 +0200 (CEST)

>> Maybe it is even possible with GNU make's string functions
> 
> I'm gonna try that, GNU make >= 4.2 supports things like
> ```
> file:=test.txt
> variable:=$(file < $(FILE))
> ```

Please don't use this – version 4.2 is too recent.  Instead, you
should use code similar to

  variable := $(shell $(CAT) $(FILE))

(cf. file `builds/toplevel.mk'), where $(CAT) is either `cat' on UNIX
or `type' on Windows and DOS.

> -#if FT_SIZEOF_INT == ( 32 / FT_CHAR_BIT )
> +#if FT_SIZEOF_INT == 4
> ...
> 
> +  /* we handle the LLP64 scheme separately for GCC and clang, */
> +  /* suppressing the `long long' warning                      */
> +#elif ( FT_SIZEOF_LONG == 4 )       && \
> +      defined( HAVE_LONG_LONG_INT ) && \
> +      defined( __GNUC__ )
> +#pragma GCC diagnostic ignored "-Wlong-long"
> +#define FT_LONG64
> +#define FT_INT64   long long int
> +#define FT_UINT64  unsigned long long int
> +
> 
> -#endif /* FT_SIZEOF_LONG == (64 / FT_CHAR_BIT) */
> +#endif /* FT_SIZEOF_LONG == 8 */
> ```
> 
> Shouldn't this be the same in both files?

Theoretically yes.  However, relying on `FT_CHAR_BIT' is not as
reliable as using the `SIZEOF_INT' and `SIZEOF_LONG' autoconf tests.


    Werner

reply via email to

[Prev in Thread] Current Thread [Next in Thread]