[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gap-dev-discuss] Cynthiune -- MusicBrainz support
From: |
Yavor Doganov |
Subject: |
Re: [Gap-dev-discuss] Cynthiune -- MusicBrainz support |
Date: |
Thu, 07 Jun 2012 17:40:44 +0300 |
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/23.2 (i486-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
Please find the patch attached. I'm not happy with it, but I guess
it's better to submit it as it is for discussion.
Caveats:
* MusicBrainz support is demoted to optional (detected
automatically). I think this is good, as it not essential
functionality for a music player.
* The test to detect the libmusicbrainz version is very weak, but I
guess that's as best as we can do without resorting to Autoconf.
It should work in most cases.
* I get occasional crashes that are extremely hard to debug and end
up often in GNUstep Back and glibc's low level memory allocation
routines. I tested only on Debian GNU/Linux with a fairly old
GNUstep installation (GUI 0.18.0), so it might be that some GUI
classes are not entirely thread-safe, or an NSLock is needed
somewhere.
* With libmusicbrainz3, the album title always coincides with the
song title, which is utterly wrong. There's no equivalent C
function to obtain the release from the track so I don't have any
clues how to fix this. mb_track_get_id and mb_release_get_id
return the same string, so quite clearly something is not right.
* I couldn't find a way to extract the release year with
libmusicbrainz3; most probably this is related with the problem
above.
* No track number extraction with both versions of the library.
Comments welcome.
musicbrainz.patch
Description: Text document