[gcmd-dev] gnome-commander-1.2.0 feature/fix request/proposal (saving window state)

[Roma]

Hi!
Using gnome-commanger I found enough annoying  (for me) misfeature: when
main window is maximized and close program, then after restart window
maximizes but in normal state, not GDK_WINDOW_STATE_MAXIMIZED. I think,
it's normal behavior, when window state restores after next program
start. I provide a simple patch to fix it.
IDEA: Save state when state change/prog exit and restore when start
(restores only maximized state).
I also add window-state-event handler to track window state change. In
it I also save current window position, rejecting unusable values (e.g.
when window is maximized, it is x=0,y=0).
PS: apropos, you are using gtk_signal_connect and so on - it's
deprecated. I can do refactoring ;)
PPS:
address@hidden /usr/src/new/gnome-commander-1.2.0]>gnome-commander

(gnome-commander:17839): Gdk-CRITICAL **: gdk_drawable_get_depth:
assertion `GDK_IS_DRAWABLE (drawable)' failed

(gnome-commander:17839): Gtk-CRITICAL **: gtk_pixmap_set: assertion
`gdk_colormap_get_visual (gtk_widget_get_colormap (GTK_WIDGET
(pixmap)))->depth == gdk_drawable_get_depth (GDK_DRAWABLE (val))' failed

(gnome-commander:17839): Gdk-CRITICAL **: gdk_drawable_get_depth:
assertion `GDK_IS_DRAWABLE (drawable)' failed

(gnome-commander:17839): Gtk-CRITICAL **: gtk_pixmap_set: assertion
`gdk_colormap_get_visual (gtk_widget_get_colormap (GTK_WIDGET
(pixmap)))->depth == gdk_drawable_get_depth (GDK_DRAWABLE (val))' failed

(gnome-commander:17839): Gdk-CRITICAL **: gdk_drawable_get_depth:
assertion `GDK_IS_DRAWABLE (drawable)' failed

(gnome-commander:17839): Gtk-CRITICAL **: gtk_pixmap_set: assertion
`gdk_colormap_get_visual (gtk_widget_get_colormap (GTK_WIDGET
(pixmap)))->depth == gdk_drawable_get_depth (GDK_DRAWABLE (val))' failed

(gnome-commander:17839): Gdk-CRITICAL **: gdk_drawable_get_depth:
assertion `GDK_IS_DRAWABLE (drawable)' failed

(gnome-commander:17839): Gtk-CRITICAL **: gtk_pixmap_set: assertion
`gdk_colormap_get_visual (gtk_widget_get_colormap (GTK_WIDGET
(pixmap)))->depth == gdk_drawable_get_depth (GDK_DRAWABLE (val))' failed

(gnome-commander:17839): Pango-WARNING **: Invalid UTF-8 string passed
to pango_layout_set_text()

(gnome-commander:17839): Gdk-CRITICAL **: gdk_drawable_get_depth:
assertion `GDK_IS_DRAWABLE (drawable)' failed

(gnome-commander:17839): Gtk-CRITICAL **: gtk_pixmap_set: assertion
`gdk_colormap_get_visual (gtk_widget_get_colormap (GTK_WIDGET
(pixmap)))->depth == gdk_drawable_get_depth (GDK_DRAWABLE (val))' failed

(gnome-commander:17839): Gdk-CRITICAL **: gdk_drawable_get_depth:
assertion `GDK_IS_DRAWABLE (drawable)' failed

(gnome-commander:17839): Gtk-CRITICAL **: gtk_pixmap_set: assertion
`gdk_colormap_get_visual (gtk_widget_get_colormap (GTK_WIDGET
(pixmap)))->depth == gdk_drawable_get_depth (GDK_DRAWABLE (val))' failed

(gnome-commander:17839): Gdk-CRITICAL **: gdk_drawable_get_depth:
assertion `GDK_IS_DRAWABLE (drawable)' failed

(gnome-commander:17839): Gtk-CRITICAL **: gtk_pixmap_set: assertion
`gdk_colormap_get_visual (gtk_widget_get_colormap (GTK_WIDGET
(pixmap)))->depth == gdk_drawable_get_depth (GDK_DRAWABLE (val))' failed

(gnome-commander:17839): Gdk-CRITICAL **: gdk_drawable_get_depth:
assertion `GDK_IS_DRAWABLE (drawable)' failed

(gnome-commander:17839): Gtk-CRITICAL **: gtk_pixmap_set: assertion
`gdk_colormap_get_visual (gtk_widget_get_colormap (GTK_WIDGET
(pixmap)))->depth == gdk_drawable_get_depth (GDK_DRAWABLE (val))' failed

(gnome-commander:17839): Gdk-CRITICAL **: gdk_drawable_get_depth:
assertion `GDK_IS_DRAWABLE (drawable)' failed

(gnome-commander:17839): Gtk-CRITICAL **: gtk_pixmap_set: assertion
`gdk_colormap_get_visual (gtk_widget_get_colormap (GTK_WIDGET
(pixmap)))->depth == gdk_drawable_get_depth (GDK_DRAWABLE (val))' failed

(gnome-commander:17839): Gdk-CRITICAL **: gdk_drawable_get_depth:
assertion `GDK_IS_DRAWABLE (drawable)' failed

(gnome-commander:17839): Gtk-CRITICAL **: gtk_pixmap_set: assertion
`gdk_colormap_get_visual (gtk_widget_get_colormap (GTK_WIDGET
(pixmap)))->depth == gdk_drawable_get_depth (GDK_DRAWABLE (val))' failed

(gnome-commander:17839): Gdk-CRITICAL **: gdk_drawable_get_depth:
assertion `GDK_IS_DRAWABLE (drawable)' failed

(gnome-commander:17839): Gtk-CRITICAL **: gtk_pixmap_set: assertion
`gdk_colormap_get_visual (gtk_widget_get_colormap (GTK_WIDGET
(pixmap)))->depth == gdk_drawable_get_depth (GDK_DRAWABLE (val))' failed

(gnome-commander:17839): Gdk-CRITICAL **: gdk_drawable_get_depth:
assertion `GDK_IS_DRAWABLE (drawable)' failed

(gnome-commander:17839): Gtk-CRITICAL **: gtk_pixmap_set: assertion
`gdk_colormap_get_visual (gtk_widget_get_colormap (GTK_WIDGET
(pixmap)))->depth == gdk_drawable_get_depth (GDK_DRAWABLE (val))' failed

(gnome-commander:17839): Pango-WARNING **: Invalid UTF-8 string passed
to pango_layout_set_text()

I can fix it too ;)
PPPS: in configure.in you are using
PLUGIN_DIR="${libdir}/${PACKAGE}/plugins". In my system
it provides #define PLUGIN_DIR
"${exec_prefix}/lib/gnome-commander/plugins" in config.h
PLUGIN_DIR="${PREFIX}/lib/${PACKAGE}/plugins" (like in 1.1.6) works well.

gnome-commander-1.2.0-maximize_fix.patch.gz
Description: GNU Zip compressed data