Ok, I got all my changes committed and tried to make useful comments for each file. I'm attaching my mail from December just in case though. It includes a good overview of all the different changes. After commit'ing everything, I was able to checkout a current copy of CVS, and I did some basic testing with connections to postgres and mysql. Everything works as expected. However, I did make two schema changes. Current users will need to change the two column names "key" to use this CVS version. Its fixed in both schema files, but I didn't provide a way to easily update it. Should this change involve incrementing the schema vesion number? I think there are still a few place that connect-> should be changed to Pconnect, but I'm not sure it makes any difference. Did Gregory find out more information about that call? Some of the price and image stuff is a little ugly, but it all works. Let me know what you think of the changes, and hopefully I will find some time to add that amazon.com function I talked about. ----- Forwarded message from Paul Holcomb <address@hidden> ----- Date: Fri, 12 Dec 2003 05:15:39 -0600 From: Paul Holcomb <address@hidden> To: "Matthew T. Jachimstal" <address@hidden> Cc: Paul Holcomb <address@hidden> Subject: UBER patch I knew we were going to wait until savannah came back up, but I have made a LARGE number of changes, so I thought I'd generate a patch and explain some of the changes I made and you can do with it what you like. Here is the overview of the changes. Note that I've tested all of these changes with postgres AND mysql. That's right it works with both now! +AdoDB changes in calling method -this is the same sort of stuff I have been doing +$dbtype wrong in viewnote.php -random error checking additions +SQL changes needed to make MySQL happy -places where "count(*)" were used changed to "count(*) AS count" -a if check on $dbtype for the $date string for "updated". No choice here, postgres and mysql are just different formats. only was needed in 1 place. +schema changes! - I couldn't figure out a good way to sanely check to see how sql92 reserved words that were column names could be set in the $sql lines so that silly logic didn't have to be done each time to see whether mysql or postgres was being used. So.. +in session, "key" is now "session_key" +in giftweb, "key" is now "schema_key" -changes in util.php and logout.php to reflect the above -new types in users for "images" and "price" -I've included and updated giftweb.sql and the new giftweb-mysql.sql +docs - I made a quick hack to README to include the mysql stuff, its incomplete right now though - I created the AUTHORS file (standard file under the autoconf specs), but I left it blank + viewnote fix for _GET var + logout.php meta refresh fix + printlist changes to allow non-sessioned users + addition of column "image" to "description" when displayed. printlist, editlist, edit, viewlist modified -file 60-60-blank.gif should be included in distro now + addition of column "price" to list when displayed (shows as avg price) printlist, editlist, edit, viewlist modified What I want to do now: Well, Christmas is fast approaching so I want to lock the code tomorrow (today) at the latest for the site my friends and family want to use. But afterwards, I have a couple goals 1) clean up code. 2) add a "amazon add" function. *evil laugh* With the addition of the price and image field and with the help of the API it should be possible to write a routine that given an ASIN or URL at amazon, it adds that item to your list, or given a wishlist URL (harder) 3) Add an notes section for the user that gives their general likes and dislikes, sizes, etc, in case people don't want to buy what's on the list. I'm not sure this feature is appropriate for the scope of the project, but I think its useful, nonetheless. Feel free to test this code at http://giftweb.blight.com FYI, my company likes to host mirrors of projects, so I'd be glad to host a mirror (or the primary) website of giftweb stuff from savannah. ----- End forwarded message ----- -- Paul Holcomb *pholcomb \@ cpoint net* Sr. Network Engineer Counterpoint Networking, Inc.
pgpBk74m6EUOs.pgp
Description: PGP signature
--- End Message ---