Re: [Gluster-devel] [PATCH BUG:3085] Make backupvolfile-server option actually work.

[Devon Miller]

I was thinking more of the case where no backup server is configured.

If the primary server fails, and a backup is not defined, then found=0 and err=0.

So, the script will eventually exit with a 0 when it really should have exited with a 1.

dcm

On Mon, Jun 27, 2011 at 8:27 AM, Jeff Darcy <address@hidden> wrote:

On 06/27/2011 08:09 AM, Devon Miller wrote:
> Mind you I haven't looked at this patch in context of the
> xlators/mount/fuse/utils/mount.glusterfs.in

> <http://mount.glusterfs.in/> file, I've just looked at the patch

> itself. However, it looks like *err* can only be set if *cmd_line1*
> is defined.

Then $err will remain at its previous value (from above the patch) of 0.
 I guess this could be problematic if the first invocation of glusterfs
populated the mount table and subsequently threw an error - almost the
exact opposite of the problem we have now.  In that case it would make
sense to check the error code *and* the mount-table contents, but I
don't see that as critical.