Re: [Gnash-commit] gnash/server/swf ASHandlers.cpp

[strk]

On Fri, Aug 11, 2006 at 10:30:20AM +0000, Vitaly Alexeev wrote:

I agree on the concept, but if the condition is due to a malformed SWF I 
think we should log that (I hate the proprietary player for not doing so!).

--strk;

> Patches:
> Index: ASHandlers.cpp
> ===================================================================
> RCS file: /sources/gnash/gnash/server/swf/ASHandlers.cpp,v
> retrieving revision 1.48
> retrieving revision 1.49
> diff -u -b -r1.48 -r1.49
> --- ASHandlers.cpp    8 Aug 2006 10:51:36 -0000       1.48
> +++ ASHandlers.cpp    11 Aug 2006 10:30:20 -0000      1.49
> @@ -160,11 +160,11 @@
>              call_method(constructor, &env, new_obj_ptr.get_ptr(), nargs, 
> first_arg_index);
>          }
>      }
> -
> -    else
> -    {
> -     assert(0);
> -    }
> +//   Vitaly: no actionscript operation should lead to crash player, 
> including "x=new MyClass();".
> +//    else
> +//    {
> +//   assert(0);
> +//    }
>  
>      return new_obj;
>  }