Re: [Gnash-commit] gnash ChangeLog server/edit_text_character.cpp

[strk]

On Sat, Sep 23, 2006 at 11:24:34PM +0200, Bastiaan Jacques wrote:
> On Thursday 21 September 2006 15:55, Sandro Santilli wrote:
> > CVSROOT:    /sources/gnash
> > Module name:        gnash
> > Changes by: Sandro Santilli <strk>  06/09/21 13:55:41
> >
> > Modified files:
> >     .              : ChangeLog
> >     server         : edit_text_character.cpp
> >
> > Log message:
> >     * server/edit_text_character.cpp (ctor): set textfield variable when
> > available.
> [snip]
> > Index: server/edit_text_character.cpp
> > ===================================================================
> [snip]
> >
> >     m_dummy_style.push_back(fill_style());
> >
> > +   //
> > +   // If this EditText definition contained a VariableName
> > +   // member, handle it by adding the textfield_variable
> > +   // to the appropriate sprite
> > +   //
> > +   const char* varname = m_def->get_variable_name().c_str();
> > +   if ( *varname )
> 
> Style nit: you could save indenting a bunch by doing..
> 
> if ( ! *varname ) {
>         reset_bounding_box(0, 0);
>       return;
> }

I'd rather move the innerblock code into a private method
(registerTextVariable, or similar)

[ savannah seems down atm ]

--strk;