[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] gnash ChangeLog gui/gui.cpp gui/gui.h
From: |
Sandro Santilli |
Subject: |
Re: [Gnash-commit] gnash ChangeLog gui/gui.cpp gui/gui.h |
Date: |
Tue, 17 Oct 2006 15:02:14 +0200 |
On Tue, Oct 17, 2006 at 02:59:54PM +0200, Udo Giacomozzi wrote:
> SS> + // TODO: the following condition seems bogus to me...
> SS> + // what about always calling expand_to_rect
> SS> + // and let rect class take care of any check ?
> SS> + if (_last_invalidated_bounds.m_x_min <=
> _last_invalidated_bounds.m_x_max)
> SS> + {
> SS> +
> draw_bounds.expand_to_rect(_last_invalidated_bounds);
> SS> + }
>
> Because _last_invalidated_bounds starts with min>max which means it is
> not used. This is not a error check, it's a check if
> _last_invalidated_bounds should be used or not.
Ok, what about adding set_null() and is_null() methods
to the 'rect' class ? At least there's some standard way
for it
--strk;