[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog gui/gtk.cpp

From: Sandro Santilli
Subject: Re: [Gnash-commit] gnash ChangeLog gui/gtk.cpp
Date: Wed, 18 Oct 2006 17:01:51 +0200

On Wed, Oct 18, 2006 at 04:48:31PM +0200, Udo Giacomozzi wrote:
> Hello Sandro,
> Wednesday, October 18, 2006, 4:17:58 PM, you wrote:
> SS> +  if ( bounds.width() > 1e10f ) {
> SS>      // Region is entire screen. Don't convert to integer as this will 
> overflow.
> Mmh, do you want to have a is_all() like is_null() ?
> I was just using a very large value which should be enough in any case
> but basically it's just a hack like min>max ...


        void set_world();
        bool is_world() const;

get_{x,y}_{min,max} and width/height should then also assert
! is_world in addition to ! is_null.
expand_to_whatever would do nothing (can't expand the world)...
transform would also keep being the world...
scale/shift also would do nothing...

I'm not sure it is worth the overhead though,
why don't we set proper bounds instead ?
(ie: look at actual stage size)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]