Re: [Gnash-commit] gnash/server shape.cpp

[strk]

On Sat, Mar 03, 2007 at 01:05:27PM +0000, Martin Guy wrote:

> +    // This test makes no sense: m_fill0 is unsigned and "1-based" -martin
>      if (m_fill0 < 0) {
>       // No interior fill.

Right, I've noticed this too. It should likely read m_fill0 == 0
if we want to check for 'No interior fill', but I don't think we
should skip the test in this case too... that's why I didn't bother
changing it for now (better to have the warning printed by compiler
at this stage).

The problem is that even shapes with *NO* fill , but only lines
should be checked for containing a point.
See DrawingApiTest.swf under misc-ming.all

--strk;